Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chromatic compound not working under y0 #6227

Merged
merged 2 commits into from
Mar 16, 2024
Merged

Fix chromatic compound not working under y0 #6227

merged 2 commits into from
Mar 16, 2024

Conversation

IThundxr
Copy link
Member

@IThundxr IThundxr commented Mar 8, 2024

Fixes #6148

@IThundxr IThundxr added pr type: fix PR fixes a bug pr flag: simple PR has minimal changes labels Mar 8, 2024
PepperCode1
PepperCode1 requested changes Mar 8, 2024
View reviewed changes
Copy link
Member

@PepperCode1 PepperCode1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the minHeight local variable, not a constant.

@IThundxr IThundxr requested a review from PepperCode1 March 8, 2024 16:19
@PepperCode1 PepperCode1 merged commit 5adb835 into Creators-of-Create:mc1.18/dev Mar 16, 2024
@IThundxr IThundxr deleted the mc1.18/fix-compound branch March 16, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PepperCode1 PepperCode1 PepperCode1 approved these changes

Assignees
No one assigned
Labels
pr flag: simple PR has minimal changes pr type: fix PR fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.18.2] Beacons below y=0 cannot turn chromatic compound into refined radiance
2 participants
@IThundxr @PepperCode1